Re: [PATCH v2 11/13] iommu/rockchip: Use OF_IOMMU to attach devices automatically

From: JeffyChen
Date: Wed Jan 17 2018 - 02:48:11 EST


On 01/17/2018 03:30 PM, Tomasz Figa wrote:
>but it's possible the probe failed after calling iommu_device_set_fwnode, so
>i'll try to add some checks here, and maybe adjust probe() to prevent it
>too.
I think iommu_device_set_fwnode() is not enough for of_iommu_xlate()
to find the IOMMU. The IOMMU is actually added to the IOMMU list by
iommu_device_register(), which is last in the sequence, so I guess we
should be fine.

hmmm, the later patch would change that ;) i'll fix it in the next version.

Best regards,
Tomasz