Re: [PATCH] [RESEND] gpu: ipu-v3: prg: avoid possible array underflow

From: Philipp Zabel
Date: Tue Jan 16 2018 - 10:02:25 EST


Hi Arnd,

On Tue, 2018-01-16 at 15:31 +0100, Arnd Bergmann wrote:
> gcc-8 reports that we access an array with a negative index
> in an error case:
>
> drivers/gpu/ipu-v3/ipu-prg.c: In function 'ipu_prg_channel_disable':
> drivers/gpu/ipu-v3/ipu-prg.c:252:43: error: array subscript -22 is below array bounds of 'struct ipu_prg_channel[3]' [-Werror=array-bounds]
>
> This moves the range check in front of the dereference.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ----
> Originally sent on Dec 4, 2017. No reply, so resending unchanged.

Thank you, applied to imx-drm/fixes.

regards
Philipp