Re: [patch 0/3] x86/pti: Fix various fallout

From: Andy Lutomirski
Date: Sat Dec 30 2017 - 21:25:42 EST




> On Dec 30, 2017, at 2:06 PM, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
>> On Sat, Dec 30, 2017 at 1:35 PM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>>
>> Linus, I suspect -rc6 is imminent, and it would be nice to at least have the LDT
>> error path fix in. I'll send you these fixes tomorrow, but feel free to pick it up
>> from email if you wanted to release -rc6 today.
>
> I'll do rc6 tomorrow probably around this time (early afternoon PST).
> So I think I should be ok just waiting for your pull request.

FWIW, I think this big is at worst just a memory leak. Once an mm has any LDT mapped, mapping a second one can't fail because the entire LDT area is under 512 pages, meaning that nothing needs to be allocated, so there's no opportunity for failure.

So it's an embarrassing bug, but not catastrophic.

>
> Thanks,
>
> Linus