Re: [PATCH] drm/vc4: Move IRQ enable to PM path

From: Stefan Wahren
Date: Sat Dec 30 2017 - 15:03:33 EST



> Stefan Schake <stschake@xxxxxxxxx> hat am 29. Dezember 2017 um 17:05 geschrieben:
>
>
> We were calling enable_irq on bind, where it was already enabled previously
> by the IRQ helper. Additionally, dev->irq is not set correctly until after
> postinstall and so was always zero here, triggering a warning in 4.15.
> Fix both by moving the enable to the power management resume path, where we
> know there was a previous disable invocation during suspend.
>
> Fixes: 253696ccd613 ("drm/vc4: Account for interrupts in flight")
> Signed-off-by: Stefan Schake <stschake@xxxxxxxxx>

Tested-by: Stefan Wahren <stefan.wahren@xxxxxxxx>