Re: [PATCH] arch/x86/boot: sizeof macro

[Ingo Molnar]

* Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:

> On Fri, Dec 29, 2017 at 8:30 PM, Saidgani Musaev <cpu808694@xxxxxxxxx> wrote:
> 
> No changelog, no explanation why...
> No SoB tag...
> 
> > -       ireg.cx  = sizeof buf;
> > +       ireg.cx  = sizeof(buf);
> 
> sizeof is operator, not a function.
> So, what are you trying to achieve?

That's true, but in the kernel coding style we use it as a function:

  triton:~/tip> git grep 'sizeof(' | wc -l
  116570

  triton:~/tip> git grep 'sizeof [:alnum:]' | wc -l
  177

Thanks,

	Ingo