Re: [PATCH] MIPS: Use proper @return keyword

From: Randy Dunlap
Date: Tue Dec 26 2017 - 11:29:24 EST


On 12/26/2017 02:55 AM, Mathieu Malaterre wrote:
> Fix non-fatal warning:
>
> arch/mips/kernel/branch.c:418: warning: Excess function parameter 'returns' description in '__compute_return_epc_for_insn'
>
> Signed-off-by: Mathieu Malaterre <malat@xxxxxxxxxx>
> ---
> arch/mips/kernel/branch.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/kernel/branch.c b/arch/mips/kernel/branch.c
> index b79ed9af9886..e0d3a432e1e3 100644
> --- a/arch/mips/kernel/branch.c
> +++ b/arch/mips/kernel/branch.c
> @@ -399,7 +399,7 @@ int __MIPS16e_compute_return_epc(struct pt_regs *regs)
> *
> * @regs: Pointer to pt_regs
> * @insn: branch instruction to decode
> - * @returns: -EFAULT on error and forces SIGILL, and on success
> + * @return: -EFAULT on error and forces SIGILL, and on success

No @, just
return: <text>

> * returns 0 or BRANCH_LIKELY_TAKEN as appropriate after
> * evaluating the branch.
> *
>


--
~Randy