Re: [PATCH 00/11] constify gpio_led

From: arvindY
Date: Mon Dec 25 2017 - 08:08:05 EST


Hi Ressell,

On Saturday 23 December 2017 03:43 PM, Russell King - ARM Linux wrote:
On Wed, Dec 20, 2017 at 02:17:41PM +0530, Arvind Yadav wrote:
gpio_led are not supposed to change at runtime.
struct gpio_led_platform_data working with const gpio_led
provided by <linux/leds.h>. So mark the non-const structs
as const.
Marking the structs as const is fine, but marking them __initconst is
not. The GPIO LED driver can be built as a module, which means it can
be loaded after the init sections have gone away. If that happens,
then we de-reference the pointer to memory that has been freed.

Please re-spin your patch set without the __initconst marking.

Thanks for reviewing, As per your comment, I will send updated
patch. Which will not include __initconst.

~arvind