Re: [PATCH v2 1/5] extcon: usbc-cros-ec: add support to notify USB type cables.

From: Lee Jones
Date: Fri Dec 15 2017 - 03:15:04 EST


> On 2017ë 12ì 13ì 19:32, Enric Balletbo i Serra wrote:
> > From: Benson Leung <bleung@xxxxxxxxxxxx>
> >
> > Extend the driver to notify host and device type cables and the presence
> > of power.
> >
> > Signed-off-by: Benson Leung <bleung@xxxxxxxxxxxx>
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
> > Reviewed-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> > ---
> > Changes since v1:
> > - Use the BIT macro. Requested by Lee Jones.
> > - Add the Reviewed-by: Chanwoo Choi.
> >
> > drivers/extcon/extcon-usbc-cros-ec.c | 142 ++++++++++++++++++++++++++++++++++-
> > include/linux/mfd/cros_ec_commands.h | 17 +++++
> > 2 files changed, 155 insertions(+), 4 deletions(-)

> Looks good to me. After reviewing the Lee Jones,
> I'll take it on next branch.

If you take it, you need to send me a pull-request to an immutable
branch.

Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>

--
Lee Jones
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog