Re: [RFC PATCH 2/2] ASoC: select sysclk clock from mlck clock provider in wm8994 driver

From: Mark Brown
Date: Thu Dec 14 2017 - 12:41:23 EST


On Thu, Dec 14, 2017 at 05:53:58PM +0100, Olivier Moysan wrote:
> When defined in device tree, MCLK1 and MCLK2 are used
> as sysclk for aif1 and aif2 interfaces respectively.

That's not a valid assumption as far as I remember? The AIFs can use
either MCLK depending on the system configuration I think.

> If clock rate is let 0, the frequency provided by
> wm8994_set_dai_sysclk() is used instead.

I'd expect this the other way around, if we didn't specify a frequency
then read it from the input otherwise try to use clk_set_rate() to
propagate things up.

Attachment: signature.asc
Description: PGP signature