Re: [PATCH v2 14/16] remoteproc: look-up pre-registered carveout by name for carveout allocation

From: Bjorn Andersson
Date: Thu Dec 14 2017 - 00:35:04 EST


On Thu 30 Nov 08:46 PST 2017, Loic Pallardy wrote:
> + /* By name */
> + mem = rproc_find_carveout_by_name(rproc, rsc->name);
> + if (mem) {
> + /*
> + * Update resource table with registered carevout information
> + */
> + rsc->len = mem->len;

You should validate that len, da and pa are compatible.

> + rsc->da = mem->da;
> + rsc->pa = rproc_va_to_pa(mem->va);
> + /* no need to register as already match one for one */
> + return 0;
> + }

Regards,
Bjorn