Re: [PATCH 1/2] hp100: Fix a possible sleep-in-atomic bug in hp100_login_to_vg_hub

From: Joe Perches
Date: Wed Dec 13 2017 - 20:21:18 EST


On Wed, 2017-12-13 at 17:47 +0800, Jia-Ju Bai wrote:
> The driver may sleep under a spinlock.
> The function call path is:
> hp100_set_multicast_list (acquire the spinlock)
> hp100_login_to_vg_hub
> schedule_timeout_interruptible --> may sleep
>
> To fix it, schedule_timeout_interruptible is replaced with udelay.
>
> This bug is found by my static analysis tool(DSAC) and checked by my code review.

Are there any current working VG/AnyLan network installations?
I rather doubt it.