Re: [PATCH 8/8] staging: pi433: replace printk calls with dev_dbg

[Valentin Vidic]

On Wed, Dec 13, 2017 at 05:52:36PM +0300, Dan Carpenter wrote:
> On Wed, Dec 13, 2017 at 03:21:56PM +0100, Valentin Vidic wrote:
> >  drivers/staging/pi433/pi433_if.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> > index 9e558154a143..02a5ba019801 100644
> > --- a/drivers/staging/pi433/pi433_if.c
> > +++ b/drivers/staging/pi433/pi433_if.c
> > @@ -720,7 +720,7 @@ pi433_tx_thread(void *data)
> >  			retval = wait_event_interruptible(device->fifo_wait_queue,
> >  							  device->free_in_fifo > 0);
> >  			if (retval) {
> > -				printk("ABORT\n");
> > +				dev_dbg(device->dev, "ABORT\n");
> >  				goto abort;
> 
> Hm...  The kernel.org version of this driver has never looked like this.
> I wonder what you are working against...

Patch was against staging-testing, in linux-next this printk looks like
this:

   if (retval) { printk("ABORT\n"); goto abort; }

-- 
Valentin