Re: [PATCH v8 4/4] KVM: X86: Add flush_on_enter before guest enter

From: Peter Zijlstra
Date: Wed Dec 13 2017 - 08:36:05 EST


On Tue, Dec 12, 2017 at 05:33:04PM -0800, Wanpeng Li wrote:
> + if (xchg(&vcpu->arch.st.steal.preempted, KVM_VCPU_NOT_PREEMPTED) ==
> + (KVM_VCPU_SHOULD_FLUSH | KVM_VCPU_PREEMPTED)) {
> + /*
> + * Do TLB_FLUSH before entering the guest, its passed
> + * the stage of request checking
> + */
> + kvm_vcpu_flush_tlb(vcpu, false);
> + }

And not a single word, _anywhere_ on why this doesn't need
invalidate_gpa or wtf that actually is.