Re: [PATCH PTI v3 03/10] x86/pti/64: Fix ESPFIX64 user mapping

From: Kirill A. Shutemov
Date: Wed Dec 13 2017 - 08:12:13 EST


On Tue, Dec 12, 2017 at 07:56:38AM -0800, Andy Lutomirski wrote:
> The ESPFIX64 user mapping belongs in pti.c just like all the other
> user mappings. Move it there and make it work correctly while we're
> at it.
>
> Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxx>

Acked-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>

BTW, why do we open-code p?d_alloc() in pti_user_pagetable_walk_*()?
It seems unnecessary and potentially bogus: see smp_wmb() in __p?d_alloc()
helpers.

--
Kirill A. Shutemov