Re: [PATCH] spi: s3c64xx: add SPDX identifier

From: Mark Brown
Date: Wed Dec 13 2017 - 04:38:20 EST


On Wed, Dec 13, 2017 at 10:48:54AM +0900, Andi Shyti wrote:

> > > +//
> > > +// Copyright (c) 2009 Samsung Electronics Co., Ltd.
> > > +// Jaswinder Singh <jassi.brar@xxxxxxxxxxx>

> it just looks ugly to me to have something like

> // SPDX...

> /*
> * Copyright (c)...
> * Jasw...
> */

> I would make everything of the '//' style (I've also seen that
> this is the trend also in other subsystems), but honestly I don't
> really care. If you're strong on not moving entirely in '//' style

Yes, my preference is to avoid a mixture like you've got there.

Attachment: signature.asc
Description: PGP signature