Re: [PATCH] drivers: base: power: Fix GFP_KERNEL in spinlock context

From: Rafael J. Wysocki
Date: Tue Dec 12 2017 - 11:55:05 EST


On Tue, Dec 12, 2017 at 2:45 PM, <shrikant.maurya@xxxxxxxxxxxx> wrote:
> From: Shrikant Maurya <shrikant.maurya@xxxxxxxxxxxx>
>
> As reported by Jia-Ju Bai (https://lkml.org/lkml/2017/12/11/872):
> API's are using GFP_KERNEL to allocate memory which may sleep.
>
> To ensure atomicity such allocations must be avoided in critical
> sections under spinlock.

That's right.

Which is why wakeup_source_create() should never be called under a spinlock.

Are you aware of any place that happens in the mainline kernel?

Thanks,
Rafael