Re: [BUG] soc/sti: a possible sleep-in-atomic bug in uni_player_ctl_iec958_put

From: Arnaud Pouliquen
Date: Tue Dec 12 2017 - 11:14:01 EST


Hello Jia-Ju,


On 12/12/2017 03:27 PM, Jia-Ju Bai wrote:
> According to sound/soc/sti/uniperif_player.c, the driver may sleep under
> a spinlock.
> The function call path is:
> uni_player_ctl_iec958_put (acquire the spinlock)
> Â uni_player_set_channel_status
> ÂÂÂ mutex_lock --> may sleep
>
> I do not find a good way to fix it, so I only report.
> This possible bug is found by my static analysis tool (DSAC) and checked
> by my code review.
you right, mutex under spin lock is not recommended... I will have a look
Thanks!

Regards
Arnaud

>
>
> Thanks,
> Jia-Ju Bai