Re: [PATCH] spi: s3c64xx: add SPDX identifier

From: Andi Shyti
Date: Tue Dec 12 2017 - 10:30:02 EST


Hi Krzysztof,

> > - * Copyright (C) 2009 Samsung Electronics Ltd.
> > - * Jaswinder Singh <jassi.brar@xxxxxxxxxxx>
> > - *
> > - * This program is free software; you can redistribute it and/or modify
> > - * it under the terms of the GNU General Public License as published by
> > - * the Free Software Foundation; either version 2 of the License, or
> > - * (at your option) any later version.
> > - *
> > - * This program is distributed in the hope that it will be useful,
> > - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > - * GNU General Public License for more details.
> > - */
> > +// SPDX-License-Identifier: GPL-2.0
>

> Existing license corresponds to GPL-2.0+, not GPL-2.0.

mmmhhh... isn't it deprecated from 2.0rc2? Current SPDX version
2.6 doesn't have GPL-2.0+ in the list of licenses.

https://spdx.org/licenses/

I can improve the commit log to state it more clearly. Would that
work?

BTW, is it really a change of license?

> Why changing the comment style?

That's SPDX, right? by adding the SPDX-License-Identifier the
GPLv2 statement becomes redundant and we can remove some lines.

Andi