Re: [PATCH] virtio_mmio: fix devm cleanup

From: Mark Rutland
Date: Tue Dec 12 2017 - 08:34:09 EST


On Tue, Dec 12, 2017 at 02:31:48PM +0100, Cornelia Huck wrote:
> On Tue, 12 Dec 2017 13:29:02 +0000
> Mark Rutland <mark.rutland@xxxxxxx> wrote:
>
> > On Tue, Dec 12, 2017 at 02:09:52PM +0100, Cornelia Huck wrote:
>
> > > Shouldn't the cleanup in _remove() then be removed as well?
> >
> > Ah, I'd missed that.
> >
> > I believe that can be removed, yes.
> >
> > Should I spin a v2 with that folded in?
>
> I think it has the same devm_ioremap vs. iounmap discrepancy, so it
> should probably be folded in.

Ah, yes. I'll spin a v2 now.

Thanks,
Mark.