Re: [PATCH] chcr: ensure cntrl is initialized to fix bit-wise or'ing of garabage data

From: Herbert Xu
Date: Mon Dec 11 2017 - 06:47:18 EST


On Thu, Nov 30, 2017 at 02:23:54PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> In the case where skb->ip_summed != CHECKSUM_PARTIAL then cntrl contains
> garbage value and this is possibly being bit-wise or'd and stored into
> cpl->ctrl1. Fix this by initializing cntrl to zero.
>
> Cleans up clang warning:
> drivers/crypto/chelsio/chcr_ipsec.c:374:9: warning: The left expression
> of the compound assignment is an uninitialized value. The computed value
> will also be garbage
>
> Fixes: 6dad4e8ab3ec ("chcr: Add support for Inline IPSec")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt