Re: [PATCH 1/2] platform/x86: wmi: prefix sysfs files in /sys/bus/wmi with the ACPI device

From: Mario.Limonciello
Date: Fri Dec 08 2017 - 22:41:10 EST


>> On Dec 8, 2017, at 6:34 PM, Mario Limonciello <mario.limonciello@xxxxxxxx> wrote:
>>
>> It's possible for the same GUID to show up on as system twice.
>> This means using solely the GUID for identify the file will not
>> be sufficient.
>
>Isn't the file already in a per-bus directory?

Yep, but the symlink created in /sys/bus/wmi/devices isn't.
That's where the kernel complains about duplicate sysfs
attributes.

It's not exactly a pretty path I submitted, but it does avoid
those collisions.

Example (with this in place from /sys/bus/wmi/devices):
lrwxrwxrwx 1 root root 0 Dec 8 21:39 PNP0C14:04-70FE8229-D03B-4214-A1C6-1F884B1A892A -> ../../../devices/platform/PNP0C14:04/wmi_bus/wmi_bus-PNP0C14:04/PNP0C14:04-70FE8229-D03B-4214-A1C6-1F884B1A892A