Re: [PATCH] bnxt_en: Fix sources of spurious netpoll warnings

From: David Miller
Date: Fri Dec 08 2017 - 14:08:40 EST


From: Michael Chan <michael.chan@xxxxxxxxxxxx>
Date: Fri, 8 Dec 2017 09:35:42 -0800

> On Fri, Dec 8, 2017 at 9:05 AM, Calvin Owens <calvinowens@xxxxxx> wrote:
>> After applying 2270bc5da3497945 ("bnxt_en: Fix netpoll handling") and
>> 903649e718f80da2 ("bnxt_en: Improve -ENOMEM logic in NAPI poll loop."),
>> we still see the following WARN fire:
...
>> This happens because we increment rx_pkts on -ENOMEM and -EIO, resulting
>> in rx_pkts > 0. Fix this by only bumping rx_pkts if we were actually
>> given a non-zero budget.
>>
>> Signed-off-by: Calvin Owens <calvinowens@xxxxxx>
>
> Thanks.
> Acked-by: Michael Chan <michael.chan@xxxxxxxxxxxx>

Applied and queued up for -stable.