Re: [PATCH] tools/slabinfo-gnuplot: force to use bash shell

From: Sergey Senozhatsky
Date: Fri Dec 08 2017 - 05:33:34 EST


On (12/08/17 17:37), Liu, Changcheng wrote:
>
> On some linux distributions, the default link of sh
> is dash which deoesn't support split array like
> ${var//,/ }
> It's better to force to use bash shell directly.
>
> Signed-off-by: Liu Changcheng <changcheng.liu@xxxxxxxxx>

Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>


-ss

> diff --git a/tools/vm/slabinfo-gnuplot.sh b/tools/vm/slabinfo-gnuplot.sh
> index 35b0398..0cf28aa 100644
> --- a/tools/vm/slabinfo-gnuplot.sh
> +++ b/tools/vm/slabinfo-gnuplot.sh
> @@ -1,4 +1,4 @@
> -#!/bin/sh
> +#!/bin/bash
>
> # Sergey Senozhatsky, 2015
> # sergey.senozhatsky.work@xxxxxxxxx
> --
> 2.7.4
>