Re: [PATCH v4] arm64: dts: rockchip: update mipi cells for RK3399

From: Doug Anderson
Date: Wed Nov 29 2017 - 15:52:36 EST


Hi,

On Wed, Nov 29, 2017 at 10:47 AM, Brian Norris <briannorris@xxxxxxxxxxxx> wrote:
> From: Nickey Yang <nickey.yang@xxxxxxxxxxxxxx>
>
> We might include additional ports in derivative device trees, so the
> 'port' node should have an address, and the parent 'ports' node needs
> /#{addres,size}-cells.
>
> v4:
> * keep #{address,size}-cells in both 'ports' and 'port@0' nodes
> * separate from the rest of the series, since this is mostly
> independent of the driver refactoring
>
> Signed-off-by: Nickey Yang <nickey.yang@xxxxxxxxxxxxxx>
> Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)

This seems sane to me according to my current understanding and
reading of the bindings.

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>