Re: [PATCH 0/4] staging: lustre: fixed some signedness warns from sparse
From: Dan Carpenter
Date: Thu Nov 23 2017 - 06:52:09 EST
On Thu, Nov 23, 2017 at 03:59:26PM +1100, Tobin C. Harding wrote:
> On Wed, Nov 22, 2017 at 08:38:27PM +0100, Stefano Manni wrote:
> > Fixed some signedness warnings from sparse on lustre.
> >
> > Stefano Manni (4):
> > staging: lustre: fixed signedness of some socklnd params
> > staging: lustre: fixed signedness of llite
> > staging: lustre: fixed signedness of lov
> > staging: lustre: fixed signedness of obdclass
>
> You may like to use imperative mood for your git log brief descriptions
> Stefano.
>
> s/fixed/fix/
>
Someone once chewed me a second butt hole for not using the imperative
mood so I know some people care intensely about this but I think so long
as you can understand the description it's fine. I will never send a
patch for that maintainer's subsystem again, btw, which is probably
grateful for and now I can poop twice as fast so we're both winners.
Especially in the 0/4 patch which is going to be discarded. Who cares?
regards,
dan carpenter