Re: [PATCH] coccinelle: flags.cocci: reorganize patterns to improve efficiency

From: Masahiro Yamada
Date: Wed Nov 15 2017 - 19:04:07 EST


2017-11-16 7:02 GMT+09:00 Joe Perches <joe@xxxxxxxxxxx>:
> On Wed, 2017-11-15 at 22:55 +0100, Julia Lawall wrote:
>> What version of Coccinelle do you have?
>> > I tried 1.0.4 and 1.0.6,
>> > but both failed.
>> For me, it also fails for 1.0.6. It should be OK for 1.0.7.
>
> Then likely this patch should not be applied or
> some form of local version checking should be done
> in the script itself.
>
> Scripts that use various tools are subject to
> language versioning requirements.
>
> For instance, there are many things that are
> possible with later versions of perl, but are not
> done for various scripts because many distributions
> do not ship with the latest versions.
>


OK.

// Requires: 1.0.7

is necessary
and applicable after coccinelle 1.0.7 is released.




--
Best Regards
Masahiro Yamada