Re: [PATCH] drm: mali-dp: Separate static internal data into a read-only structure.

[Gustavo Padovan]

Hi Liviu,

2017-11-01 Liviu Dudau <Liviu.Dudau@xxxxxxx>:

> The malidp_hw_device structure that the driver uses to handle the
> differences between versions of the IP contains both non-changeable
> data and fields that get updated at probe time. Previously we were
> copying the read-only part into allocated memory, but that can be
> completely avoided by splitting the structure into a read-only part
> and keeping the runtime modifiable fields into the old structure.
> 
> Reviewed-by: Brian Starkey <brian.starkey@xxxxxxx>
> Signed-off-by: Liviu Dudau <liviu.dudau@xxxxxxx>
> ---
>  drivers/gpu/drm/arm/malidp_crtc.c   | 13 ++++----
>  drivers/gpu/drm/arm/malidp_drv.c    | 30 ++++++++---------
>  drivers/gpu/drm/arm/malidp_hw.c     | 46 ++++++++++++++------------
>  drivers/gpu/drm/arm/malidp_hw.h     | 65 ++++++++++++++++++++++---------------
>  drivers/gpu/drm/arm/malidp_planes.c | 19 +++++------
>  5 files changed, 93 insertions(+), 80 deletions(-)

Reviewed-by: Gustavo Padovan <gustavo.padovan@xxxxxxxxxxxxx>

Gustavo