Re: [PATCH V2 2/2] mfd: cros ec: spi: Simplify delay handling between SPI messages

From: Doug Anderson
Date: Tue Nov 14 2017 - 13:47:44 EST


Hi,

On Tue, Nov 14, 2017 at 6:43 AM, Jon Hunter <jonathanh@xxxxxxxxxx> wrote:
> The EC SPI driver prevents SPI transfers being to rapidly by keeping
> track of the time the last transfer was issued via the
> 'last_transfer_ns' variable. Previously, if the 'last_transfer_ns'
> variable was zero, this indicated that no previous transfer had been
> sent and that no delay was needed. However, the EC SPI driver has
> been updated to always initialise the 'last_transfer_ns' variable
> during probe and therefore, it is no longer necessary to test if it
> is zero. Remove the code that checks if this variable is zero.
>
> Signed-off-by: Jon Hunter <jonathanh@xxxxxxxxxx>
> Reviewed-by: Brian Norris <briannorris@xxxxxxxxxxxx>
> ---
> Changes since V1:
> - Added Brian's reviewed-by.
>
> drivers/mfd/cros_ec_spi.c | 25 +++++++++----------------
> 1 file changed, 9 insertions(+), 16 deletions(-)

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>