Re: [PATCH] mm: drop hotplug lock from lru_add_drain_all

From: Michal Hocko
Date: Tue Nov 14 2017 - 10:15:12 EST


On Tue 14-11-17 16:05:21, Thomas Gleixner wrote:
> On Tue, 14 Nov 2017, Michal Hocko wrote:
>
> > On Tue 14-11-17 15:23:47, Michal Hocko wrote:
> > [...]
> > > +/*
> > > + * Doesn't need any cpu hotplug locking because we do rely on per-cpu
> > > + * kworkers being shut down before our page_alloc_cpu_dead callback is
> > > + * executed on the offlined cpu
> > > + */
> > > void lru_add_drain_all(void)
> > > {
> > > static DEFINE_MUTEX(lock);
> >
> > Ble the part of the comment didn't go through
>
> Looks good.

Thanks! I have folded that to the patch and will wait a day or two for
more comments and then resubmit.
--
Michal Hocko
SUSE Labs