RE: [PATCH] refcount: provide same memory ordering guarantees as in atomic_t

From: Reshetova, Elena
Date: Tue Nov 14 2017 - 06:24:06 EST


> On Mon, Nov 13, 2017 at 04:01:11PM +0000, Reshetova, Elena wrote:
> >
> > > On Mon, Nov 13, 2017 at 09:09:57AM +0000, Reshetova, Elena wrote:
> > > > <snip>
> > > >
> > > > > Note that there's work done on better documents and updates to this one.
> > > > > One document that might be good to read (I have not in fact had time to
> > > > > read it myself yet :-():
> > > > >
> > > > > https://github.com/aparri/memory-
> > > > > model/blob/master/Documentation/explanation.txt
> > > >
> > > > I have just finished reading over this and must say that this is excellent.
> > > > If I would have started reading on this topic from this doc and then move
> > > > to other in-tree docs, including memory-barriers.txt, I would
> > > > have had much less issues/questions and it would be much less of a bumpy
> > > > read.
> > >
> > > Glad you like it! May we have your Acked-by?
> >
> > I think my Acked-by has little value in this case since I am really a beginner in it
> > myself, but I would strongly suggest to Peter and others to consider inclusion
> > of this doc into the tree since I do see a value in it. Again, I am not really an
> > important person here :)
>
> I respectfully disagree.
>
> The fact that this file was helpful to a self-described beginner
> such as yourself is -way- more important than it being helpful to us
> battlescarred veterans.
>
> Besides, Peter already agreed, perhaps in a moment of weakness, to
> allow his name to be added to this patch.
>
> In any case, it is your choice, but I personally would value your
> Acked-by.

Sure, please feel free to add it if it is of any help/value!

Best Regards,
Elena.

>
> > > > Is there any plan to include it into official kernel doc tree? I really think it
> > > > would be very helpful for others also even basically to explain the notations,
> > > properties
> > > > and language people talk about these issues and give examples.
> > >
> > > Yes, we do plan to submit it for inclusion.
> >
> > Great, I think it would help people!
>
> Here is hoping! ;-)
>
>
> Thanx, Paul
>
> > Best Regards,
> > Elena.
> >
> > >
> > >
> > > Thanx, Paul
> > >
> > > > I will try to improve a bit the new doc I have previously sent a patch for in the
> > > > spirit of this reading.
> > > >
> > > >
> > > > Best Regards,
> > > > Elena.
> > > >
> >