Re: [PATCH 5/7] perf tests: Set evlist of test__task_exit() to !overwrite

From: Arnaldo Carvalho de Melo
Date: Mon Nov 13 2017 - 13:32:39 EST


Em Mon, Nov 13, 2017 at 01:38:07AM +0000, Wang Nan escreveu:
> Changing ringbuffer to !overwrite in this task is harmless because
> this test uses a very low frequency (1) and using a very simple
> program (true). There should have only 3 events in the whole test.
> Overwriting is impossible to happen.

applied

> Signed-off-by: Wang Nan <wangnan0@xxxxxxxxxx>
> ---
> tools/perf/tests/task-exit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/task-exit.c b/tools/perf/tests/task-exit.c
> index f0881d0..4fb6609 100644
> --- a/tools/perf/tests/task-exit.c
> +++ b/tools/perf/tests/task-exit.c
> @@ -96,7 +96,7 @@ int test__task_exit(struct test *test __maybe_unused, int subtest __maybe_unused
> goto out_delete_evlist;
> }
>
> - if (perf_evlist__mmap(evlist, 128, true) < 0) {
> + if (perf_evlist__mmap(evlist, 128, false) < 0) {
> pr_debug("failed to mmap events: %d (%s)\n", errno,
> str_error_r(errno, sbuf, sizeof(sbuf)));
> goto out_delete_evlist;
> --
> 2.10.1