Re: [PATCH] clocksource/drivers/timer-of: mark timer_of_exit as __init

From: Thomas Gleixner
Date: Mon Nov 13 2017 - 10:10:15 EST


On Mon, 13 Nov 2017, Daniel Lezcano wrote:
> On 13/11/2017 11:11, Sudeep Holla wrote:
> > Agreed, may be if we add users which is called from init functions, the
> > warning should disappear. Also as tglx suggested, we could rename if it's
> > just used from init function error/exit paths.
>
> The drivers are not compiled as module AFAICT, the function will be
> called in the init error path.

Ok, if the consensus is that this is used for common cleanup in __init
error handling, then please can someone submit a new version of this which
renames the function to something like timer_of_cleanup() and add the
__init annotation to it? And while at it please add a kernel doc comment to
that effect.

Thanks,

tglx