Re: [PATCH 3/5] staging: speakup: Apply format_template attribute

From: Greg Kroah-Hartman
Date: Mon Nov 13 2017 - 09:00:47 EST


On Sun, Nov 12, 2017 at 10:19:09PM +0100, Rasmus Villemoes wrote:
> This serves as human-readable documentation as well as allowing the
> format_template plugin to complain about any static initializers of this
> struct member that do not have the same set of printf specifiers.
>
> Signed-off-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>
> ---
> drivers/staging/speakup/spk_types.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/spk_types.h b/drivers/staging/speakup/spk_types.h
> index c50de6035a9a..156000c0c4d3 100644
> --- a/drivers/staging/speakup/spk_types.h
> +++ b/drivers/staging/speakup/spk_types.h
> @@ -108,7 +108,7 @@ struct st_var_header {
> };
>
> struct num_var_t {
> - char *synth_fmt;
> + char *synth_fmt __format_template("%d");
> int default_val;
> int low;
> int high;
> --
> 2.11.0

Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>