Re: [PATCH] omap3-n900: enable autofocus

From: Sebastian Reichel
Date: Sun Nov 12 2017 - 09:29:26 EST


Hi,

On Sun, Nov 12, 2017 at 12:25:29PM +0100, Pavel Machek wrote:
>
> Connect auto-focus coil to the camera sensor, so that it can be used
> by camera applications.
>
> Signed-off-by: Pavel Machek <pavel@xxxxxx>

I think you should replace auto-focus with lens-focus. This is not
automatic. Otherwise:

Reviewed-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxxxx>

-- Sebastian

> diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
> index 669c51c..59cc743 100644
> --- a/arch/arm/boot/dts/omap3-n900.dts
> +++ b/arch/arm/boot/dts/omap3-n900.dts
> @@ -778,6 +778,8 @@
>
> reset-gpio = <&gpio4 6 GPIO_ACTIVE_HIGH>; /* 102 */
>
> + lens-focus = <&ad5820>;
> +
> port {
> csi_cam1: endpoint {
> bus-type = <3>; /* CCP2 */
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


Attachment: signature.asc
Description: PGP signature