Re: [PATCH 14/14] nubus: Add support for the driver model

[Greg Kroah-Hartman]

On Sat, Nov 11, 2017 at 09:45:53AM +0100, Greg Kroah-Hartman wrote:
> On Sat, Nov 11, 2017 at 01:12:49AM -0500, Finn Thain wrote:
> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Tested-by: Stan Johnson <userm57@xxxxxxxxx>
> > Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>
> > ---
> 
> I can't take patches without any changelog text at all, that's not good
> engineering, sorry :(
> 
> Please fix up and resend and I will be glad to review.

Also, please test device removal, I don't think you did that :(