Re: [PATCH 00/10] scripts/basic: Fine-tuning for seven function implementations

From: SF Markus Elfring
Date: Fri Nov 10 2017 - 13:32:28 EST


> Date: Fri, 28 Oct 2016 10:18:10 +0200
>
> Some update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (10):
> bin2c: Complete error handling in main()
> fixdep: Complete error handling in print_deps()
> fixdep: Use the symbol "MAP_FAILED" in print_deps()
> fixdep: Fix error log output in print_deps()
> fixdep: Complete error handling in parse_dep_file()
> fixdep: Complete error handling in do_config_file()
> fixdep: Fix error log output in do_config_file()
> fixdep: Complete error handling in print_config()
> fixdep: Complete error handling in print_cmdline()
> fixdep: Combine two fprintf() calls into one fputs() call in usage()
>
> scripts/basic/bin2c.c | 26 ++++++----
> scripts/basic/fixdep.c | 131 +++++++++++++++++++++++++++++++++----------------
> 2 files changed, 105 insertions(+), 52 deletions(-)

Are these update suggestions worth for another look?
https://lkml.org/lkml/2016/10/28/138

Regards,
Markus