Re: [PATCH 18/27] bpf: Restrict kernel image access functions when the kernel is locked down

From: David Howells
Date: Thu Nov 09 2017 - 12:15:46 EST


Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> wrote:

> > TBH, I've no idea how bpf does anything, so I can't say whether this is
> > better, overkill or insufficient.
>
> ok. To make it clear:
> Nacked-by: Alexei Starovoitov <ast@xxxxxxxxxx>
> For the current patch.
> Unnecessary checks for no good reason in performance critical
> functions are not acceptable.

They aren't unnecessary checks.

Can you please suggest if there's some way more suitable than just killing bpf
entirely? I don't know the code, and I presume you do.

David