Re: [PATCH 2/4] arm64: dts: qcom: msm8916-pins: remove assignments to bias-disable

From: Bjorn Andersson
Date: Thu Nov 09 2017 - 11:50:11 EST


On Wed 01 Nov 10:53 PDT 2017, Damien Riegel wrote:

> Drop assignments to bias-disable as the documentation [1] states that
> this property doesn't take a value. Other occurrences of this property
> respect that.
>
> [1] Documentation/devicetree/bindings/pinctrl/qcom,msm8916-pinctrl.txt
>

Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>

Regards,
Bjorn

> Signed-off-by: Damien Riegel <damien.riegel@xxxxxxxxxxxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/msm8916-pins.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi b/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi
> index 4cb0b5834143..c67ad8ed8b60 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi
> @@ -278,7 +278,7 @@
> pinconf {
> pins = "gpio6", "gpio7";
> drive-strength = <16>;
> - bias-disable = <0>;
> + bias-disable;
> };
> };
>
> @@ -290,7 +290,7 @@
> pinconf {
> pins = "gpio6", "gpio7";
> drive-strength = <2>;
> - bias-disable = <0>;
> + bias-disable;
> };
> };
>
> @@ -302,7 +302,7 @@
> pinconf {
> pins = "gpio14", "gpio15";
> drive-strength = <16>;
> - bias-disable = <0>;
> + bias-disable;
> };
> };
>
> @@ -314,7 +314,7 @@
> pinconf {
> pins = "gpio14", "gpio15";
> drive-strength = <2>;
> - bias-disable = <0>;
> + bias-disable;
> };
> };
>
> @@ -326,7 +326,7 @@
> pinconf {
> pins = "gpio22", "gpio23";
> drive-strength = <16>;
> - bias-disable = <0>;
> + bias-disable;
> };
> };
>
> @@ -338,7 +338,7 @@
> pinconf {
> pins = "gpio22", "gpio23";
> drive-strength = <2>;
> - bias-disable = <0>;
> + bias-disable;
> };
> };
>
> --
> 2.15.0
>