Re: [PATCH 30/31] dt-bindings: nds32 CPU Bindings

From: Rob Herring
Date: Thu Nov 09 2017 - 08:58:17 EST


On Thu, Nov 9, 2017 at 3:39 AM, Greentime Hu <green.hu@xxxxxxxxx> wrote:
> 2017-11-08 21:18 GMT+08:00 Rob Herring <robh+dt@xxxxxxxxxx>:
>> Please Cc the DT list on bindings.
>
> Sorry. I am not sure what you mean.
> Do you mean add devicetree@xxxxxxxxxxxxxxx to cc list?

Yes. Use get_maintainers.pl as a guide.

>> On Tue, Nov 7, 2017 at 11:55 PM, Greentime Hu <green.hu@xxxxxxxxx> wrote:
>>> From: Greentime Hu <greentime@xxxxxxxxxxxxx>
>>

>>> + device_type = "cpu";
>>> + compatible = "andestech,n13", "andestech,n15";
>>
>> n13 is a superset of n15?
>
> No, they are independent ones.

Then having both is not valid. The strings should be in order of best
match to worst match where worst match is typically either older
implementations of IP blocks or generic'ish strings such as "ns16550"
for a UART.

Rob