Re: [PATCH net-next 1/2] net: hns3: fix a bug when getting phy address from NCL_config file

From: lipeng (Y)
Date: Wed Nov 08 2017 - 21:03:23 EST




On 2017/11/8 22:30, Andrew Lunn wrote:
On Wed, Nov 08, 2017 at 03:52:22PM +0800, Lipeng wrote:
From: Fuyun Liang <liangfuyun1@xxxxxxxxxx>

Driver gets phy address from NCL_config file and uses the phy address
to initialize phydev. There are 5 bits for phy address. And C22 phy
address has 5 bits. So 0-31 are all valid address for phy. If there
is no phy, it will crash. Because driver always get a valid phy address.
Hi Lipeng

Any plans for C45? The PHY address is still 5 bits, but do you need to
get the device type from your configuration file?

Andrew
Hi Andrew

C45 support is in Plan, now only support C22.
This bugfix patch is valid for C22 and C45.

As plan , will get the device type(NULL, C22, C45) from configuration file after support C45.
Do you think we must do it now? or can add it along with C45 support?

Lipeng
.