Re: [PATCH v2] rtc: rx8010: Fix for incorrect return value

From: Alexandre Belloni
Date: Wed Nov 08 2017 - 19:18:39 EST


On 08/11/2017 at 14:58:14 -0500, Akshay Bhat wrote:
> The err variable is not being reset after a successful read. Explicitly
> return 0 at the end of function call to account for all return paths.
>
> Reported-by: Jens-Peter Oswald <oswald@xxxxxx>
> Signed-off-by: Akshay Bhat <akshay.bhat@xxxxxxxxxxx>
> ---
> v2: Address comments from Alexandre Belloni
> - Return 0 at end of function instead of resetting err variable
>
> drivers/rtc/rtc-rx8010.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Applied, thanks.

--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com