Re: [PATCH] net/mlx5e/core/en_fs: fix pointer dereference after free in mlx5e_execute_l2_action

From: Gustavo A. R. Silva
Date: Wed Nov 08 2017 - 15:55:30 EST



Quoting David Miller <davem@xxxxxxxxxxxxx>:

From: "Gustavo A. R. Silva" <garsilva@xxxxxxxxxxxxxx>
Date: Sat, 4 Nov 2017 22:54:53 -0500

hn is being kfree'd in mlx5e_del_l2_from_hash and then dereferenced
by accessing hn->ai.addr

Fix this by copying the MAC address into a local variable for its safe use
in all possible execution paths within function mlx5e_execute_l2_action.

Addresses-Coverity-ID: 1417789
Fixes: eeb66cdb6826 ("net/mlx5: Separate between E-Switch and MPFS")
Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>

Applied and queued up for -stable, thanks.

Awesome. Thanks!

--
Gustavo A. R. Silva