Re: [PATCH] apparmor: fix off-by-one comparison on MAXMAPPED_SIG

From: John Johansen
Date: Wed Nov 08 2017 - 14:12:05 EST


On 11/08/2017 10:53 AM, Linus Torvalds wrote:
> On Wed, Nov 8, 2017 at 8:09 AM, John Johansen
> <john.johansen@xxxxxxxxxxxxx> wrote:
>>
>> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>> Signed-off-by: John Johansen <john.johansen@xxxxxxxxxxxxx>
>
> This sign-off chain is odd. It implies that the patch came from Colin
> King, bnut it lacks authorship attribution.
>
> So who authored this?
>
> If it was Colin, there should have been a
>
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> at the top.
>
> So either the authorship is broken, or the sign-off chain is. Which is it?
>
The initial patch is from Colin it covered the 1st of the 2 cases. I edited the
patch, adding the second case and added a revision note then I messed up the mail.
Rushing to get this out (I dumped it into the regular mail client instead of
using git mail).

I should have just sent the request pull

The following changes since commit 8b50f0a6261b3b6e6c7ef9febe7ab8a973243ba3:

apparmor: fix off-by-one comparison on MAXMAPPED_SIG (2017-11-08 07:49:53 -0800)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/jj/linux-apparmor aa-for-up

for you to fetch changes up to 8b50f0a6261b3b6e6c7ef9febe7ab8a973243ba3:

apparmor: fix off-by-one comparison on MAXMAPPED_SIG (2017-11-08 07:49:53 -0800)

----------------------------------------------------------------