Re: [PATCH] s390/virtio: mark headers as BSD licensed

From: Greg Kroah-Hartman
Date: Wed Nov 08 2017 - 12:28:36 EST


On Wed, Nov 08, 2017 at 06:47:18PM +0200, Michael S. Tsirkin wrote:
> Virtio UAPI headers aren't just for UAPI, it's for guests/hypervisors as
> well. The s390 ones need to be BSD as well.
>
> Fixes: e2be04c7f995 ("License cleanup: add SPDX license identifier to uapi header files with a license")
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> ---
>
> Christian, I would appreciate your ack if you agree.

You are changing the license on this file, you can't just slap a BSD one
on the top, and have GPL below it without saying something about both
covering the file, right?



>
> arch/s390/include/uapi/asm/kvm_virtio.h | 26 ++++++++++++++++++++++-
> arch/s390/include/uapi/asm/virtio-ccw.h | 37 ++++++++++++++++++++++++++++++++-
> 2 files changed, 61 insertions(+), 2 deletions(-)
>
> diff --git a/arch/s390/include/uapi/asm/kvm_virtio.h b/arch/s390/include/uapi/asm/kvm_virtio.h
> index 7328367..1773693 100644
> --- a/arch/s390/include/uapi/asm/kvm_virtio.h
> +++ b/arch/s390/include/uapi/asm/kvm_virtio.h
> @@ -1,4 +1,28 @@
> -/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */

There is a dual-license SPDX identifier you can use, please use that, if
you agree to relicense this file.

thanks,

greg k-h