Re: [PATCH 2/2] Subject: printk: Don't trap random context in infinite log_buf flush

From: Steven Rostedt
Date: Wed Nov 08 2017 - 11:20:14 EST


On Mon, 6 Nov 2017 16:22:54 -0800
Tejun Heo <tj@xxxxxxxxxx> wrote:

> Hello,
>
> On Sat, Nov 04, 2017 at 01:24:08PM +0900, Sergey Senozhatsky wrote:
> > thanks for the patch set. we are currently looking at another approach:
> > lkml.kernel.org/r/20171102134515.6eef16de@xxxxxxxxxxxxxxxxxx
> >
> > would you be interested in taking a look?
>
> Hmm... It took some tweaking but the code at the end locks up the
> machine w/ Steven's patch applied and it's not that contrived a case
> (e.g. out of memory messages from packet tx/rx paths while OOM is in
> progress).

Did you apply it with or without the while (READ_ONCE(console_waiter))
fix?

Because that is crucial.

-- Steve