Re: [PATCH v2 1/3] Input: ad7897 - use managed allocated resources

From: Andi Shyti
Date: Wed Nov 08 2017 - 10:36:35 EST


> > - ts = kzalloc(sizeof(struct ad7877), GFP_KERNEL);
> > - input_dev = input_allocate_device();
> > - if (!ts || !input_dev) {
> > - err = -ENOMEM;
> > - goto err_free_mem;
> > - }
> > + ts = devm_kzalloc(&spi->dev, sizeof(struct ad7877), GFP_KERNEL);
> > + input_dev = devm_input_allocate_device(&spi->dev);
> > + if (!input_dev)
>
> You removed the check for 'ts' here and only added it back in patch 3.

Oh yes, because I squashed the 5 patches I sent earlier and I
forgot about this.

Thanks!

Andi