Re: [PATCH] s390/dasd: avoid calling do_gettimeofday()

From: Arnd Bergmann
Date: Wed Nov 08 2017 - 08:56:30 EST


On Wed, Nov 8, 2017 at 2:27 PM, Stefan Haberland <sth@xxxxxxxxxxxxxxxxxx> wrote:
> On 06.11.2017 15:02, Arnd Bergmann wrote:
>> diff --git a/drivers/s390/block/dasd_eer.c b/drivers/s390/block/dasd_eer.c
>> index 4630782b5456..5169c717c9d6 100644
>> --- a/drivers/s390/block/dasd_eer.c
>> +++ b/drivers/s390/block/dasd_eer.c
>> @@ -296,7 +296,7 @@ static void dasd_eer_write_standard_trigger(struct
>> dasd_device *device,
>> {
>> struct dasd_ccw_req *temp_cqr;
>> int data_size;
>> - struct timeval tv;
>> + struct timespec64 ts64;
>
> ...
>>
>> + ktime_get_real_ts64(&ts);
>> + header.tv_sec = ts.tv_sec;
>> + header.tv_usec = ts.tv_nsec / NSEC_PER_USEC;
>>
>
> I renamed ts64 to ts to match the usage below and fix the compile error.
>
> Beside of this, applied. Thanks for the patch.
>

Thanks and sorry for not build-testing it properly, I thought I had at
least compiled
this one separately with my cross-toolchain, but maybe I renamed the variable
after testing it, or I misremember testing it.

Arnd