Re: [PATCH] lost path_put in perf_fill_ns_link_info

From: Vasily Averin
Date: Wed Nov 08 2017 - 08:04:57 EST


On 2017-11-08 15:09, Alexander Shishkin wrote:
> On Mon, Nov 06, 2017 at 09:22:18AM +0300, Vasily Averin wrote:
>> Fixes: commit e422267322cd ("perf: Add PERF_RECORD_NAMESPACES to include namespaces related info")
>> Signed-off-by: Vasily Averin <vvs@xxxxxxxxxxxxx>
>
> The change description is missing. One needs to open the source code and
> look for proof of correctness for this patch.

perf_fill_ns_link_info() calls ns_get_path()
it returns ns_path with increased mnt and dentry counters.

Problem is that nodody decrement these counters.

You can call ./perf record --namespaces unshare -m
and look how grows mount counter on nsfs_mnt.