Re: [tip:sched/core] sched/core: Optimize sched_feat() for !SCHED_DEBUG builds

From: Patrick Bellasi
Date: Wed Nov 08 2017 - 06:25:01 EST


On 08-Nov 11:02, Patrick Bellasi wrote:
> On 08-Nov 11:03, Ingo Molnar wrote:
> >
> > * tip-bot for Patrick Bellasi <tipbot@xxxxxxxxx> wrote:
> >
> > > Commit-ID: 692ee9a79c14c9f707eeb03754a26b9427c0e005
> > > Gitweb: https://git.kernel.org/tip/692ee9a79c14c9f707eeb03754a26b9427c0e005
> > > Author: Patrick Bellasi <patrick.bellasi@xxxxxxx>
> > > AuthorDate: Tue, 7 Nov 2017 16:06:58 +0000
> > > Committer: Ingo Molnar <mingo@xxxxxxxxxx>
> > > CommitDate: Wed, 8 Nov 2017 10:17:29 +0100
> > >
> > > sched/core: Optimize sched_feat() for !SCHED_DEBUG builds
> >
> > Hm, I noticed this too late, but lots of architecture defconfig builds now produce
> > a ton of warnings:
> >
> > In file included from /home/mingo/tip/kernel/sched/idle.c:19:0:
> > /home/mingo/tip/kernel/sched/sched.h:1275:33: warning: 'sysctl_sched_features' defined but not used [-Wunused-variable]
> > static const_debug unsigned int sysctl_sched_features =
> > ^

Perhaps just using a "__maybe_unused" attribute should fix the problem.

Going to compile test with some more archs, can you tell me a
defconfig failing for you?

> > I'm dropping this patch for now.
>
> Ok Ingo, thanks.
> Actually, my fault I did not checked archs other then arm64 and x86_64.
> I'll look into this and respin a clean new version.
>
> > Thanks,
> >
> > Ingo
>
> Cheers Patrick
>
> --
> #include <best/regards.h>
>
> Patrick Bellasi

--
#include <best/regards.h>

Patrick Bellasi