Re: [PATCH net] qmi_wwan: Add missing skb_reset_mac_header-call

From: David Miller
Date: Wed Nov 08 2017 - 02:12:08 EST


From: Kristian Evensen <kristian.evensen@xxxxxxxxx>
Date: Tue, 7 Nov 2017 13:47:56 +0100

> When we receive a packet on a QMI device in raw IP mode, we should call
> skb_reset_mac_header() to ensure that skb->mac_header contains a valid
> offset in the packet. While it shouldn't really matter, the packets have
> no MAC header and the interface is configured as-such, it seems certain
> parts of the network stack expects a "good" value in skb->mac_header.
>
> Without the skb_reset_mac_header() call added in this patch, for example
> shaping traffic (using tc) triggers the following oops on the first
> received packet:
...
> While the oops is for a 4.9-kernel, I was able to trigger the same oops with
> net-next as of yesterday.
>
> Signed-off-by: Kristian Evensen <kristian.evensen@xxxxxxxxx>

Applied, with Fixes: tag added, and queued up for -stable.

Thanks!